Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: Release 1.4
-
Component/s: Tag Library
-
Labels:None
Description
Creating on behalf of Jeppe who requested this in the comments of another issue. The idea would be to localize the text that the user sees for each option.
Jeppe: do you have a good idea of how you would like this to work? Should the lookup using the 'value' attribute supplied, or the 'label' attribute supplied? Do you think this should lookup using className.value or something else?
Activity
Any progress on this one? Today, I discovered my need for this 
I patched InputOptionsCollectionTag#doStartTag() like this:
...
Object label = null;
if (labelProperty != null) {
label = OgnlUtil.getValue(labelProperty, item);
String localizedLabel = LocalizationUtility.getLocalizedFieldName(label.toString(), ((InputTagSupport) getParent()).getParentFormTag().getAction(), locale);
if (localizedLabel != null) {
label = localizedLabel;
}
}
else {
label = item;
}
...
This works for me though it is not conform with Jeppe's/Tim's idea to use the "value" attribute to lookup the localized values. In my use case, I have to localize special labels but the "value" attribute is rendered using an id so I have to use the "label"-attribute as resource key.
Maybe we could cascade the lookup like this (execution stops with non-null result):
- lookup by "label" (and actionPath."label") - [only if label is present!]
- lookup by "value" (and actionPath."value")
- use label (no lookup)
- use value as label
What do you think?
I patched InputOptionsCollectionTag#doStartTag() like this:
...
Object label = null;
if (labelProperty != null) {
label = OgnlUtil.getValue(labelProperty, item);
String localizedLabel = LocalizationUtility.getLocalizedFieldName(label.toString(), ((InputTagSupport) getParent()).getParentFormTag().getAction(), locale);
if (localizedLabel != null) {
label = localizedLabel;
}
}
else {
label = item;
}
...
This works for me though it is not conform with Jeppe's/Tim's idea to use the "value" attribute to lookup the localized values. In my use case, I have to localize special labels but the "value" attribute is rendered using an id so I have to use the "label"-attribute as resource key.
Maybe we could cascade the lookup like this (execution stops with non-null result):
- lookup by "label" (and actionPath."label") - [only if label is present!]
- lookup by "value" (and actionPath."value")
- use label (no lookup)
- use value as label
I think it should lookup using the value.
I think using the className.value as lookup key is reasonable
/Jeppe